From 9f3fdf55054827507ca324129436d23490789144 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1rk=20Tolm=C3=A1cs?= Date: Thu, 12 Jun 2025 10:39:50 +0200 Subject: [PATCH] fix: Test hook usage in production code (#9645) --- packages/excalidraw/renderer/helpers.ts | 13 +++++-------- packages/excalidraw/renderer/interactiveScene.ts | 9 +++++++-- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/packages/excalidraw/renderer/helpers.ts b/packages/excalidraw/renderer/helpers.ts index 9dd26df646..c94bcd8eb6 100644 --- a/packages/excalidraw/renderer/helpers.ts +++ b/packages/excalidraw/renderer/helpers.ts @@ -16,6 +16,7 @@ import { } from "@excalidraw/math"; import type { + ElementsMap, ExcalidrawDiamondElement, ExcalidrawRectanguloidElement, } from "@excalidraw/element/types"; @@ -128,14 +129,12 @@ function drawCatmullRomCubicApprox( export const drawHighlightForRectWithRotation = ( context: CanvasRenderingContext2D, element: ExcalidrawRectanguloidElement, + elementsMap: ElementsMap, padding: number, ) => { const [x, y] = pointRotateRads( pointFrom(element.x, element.y), - elementCenterPoint( - element, - window.h.app.scene.getElementsMapIncludingDeleted(), - ), + elementCenterPoint(element, elementsMap), element.angle, ); @@ -289,13 +288,11 @@ export const drawHighlightForDiamondWithRotation = ( context: CanvasRenderingContext2D, padding: number, element: ExcalidrawDiamondElement, + elementsMap: ElementsMap, ) => { const [x, y] = pointRotateRads( pointFrom(element.x, element.y), - elementCenterPoint( - element, - window.h.app.scene.getElementsMapIncludingDeleted(), - ), + elementCenterPoint(element, elementsMap), element.angle, ); context.save(); diff --git a/packages/excalidraw/renderer/interactiveScene.ts b/packages/excalidraw/renderer/interactiveScene.ts index 40bce1c7d0..1f3e0ff21d 100644 --- a/packages/excalidraw/renderer/interactiveScene.ts +++ b/packages/excalidraw/renderer/interactiveScene.ts @@ -205,10 +205,15 @@ const renderBindingHighlightForBindableElement = ( case "embeddable": case "frame": case "magicframe": - drawHighlightForRectWithRotation(context, element, padding); + drawHighlightForRectWithRotation(context, element, elementsMap, padding); break; case "diamond": - drawHighlightForDiamondWithRotation(context, padding, element); + drawHighlightForDiamondWithRotation( + context, + padding, + element, + elementsMap, + ); break; case "ellipse": { const [x1, y1, x2, y2] = getElementAbsoluteCoords(element, elementsMap);