corkine/squoosh
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #784 from petele/analytics-update-3

Browse Source 
Don't fire install analytics on hidden pages
This commit is contained in:
Pete LePage
2020-07-31 10:43:40 -04:00
committed by GitHub
parent ed451e4dfa ecb0b15cdc
commit 87955ab9a0
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/intro/index.tsx
View File

@ -152,13 +152,20 @@ export default class Intro extends Component<Props, State> {
@bind
private onAppInstalled() {
// We don't need the install button, if it's shown
this.setState({ beforeInstallEvent: undefined });
// Don't log analytics if page is not visible
if (document.hidden) {
return;
}
// Try to get the install, if it's not set, use 'browser'
const source = this.installingViaButton ? installButtonSource : 'browser';
ga('send', 'event', 'pwa-install', 'installed', source);
// Clear the install method property
this.installingViaButton = false;
// We don't need the install button, if it's shown
this.setState({ beforeInstallEvent: undefined });
}
render({ }: Props, { fetchingDemoIndex, beforeInstallEvent }: State) {

2
src/index.ts
View File

@ -24,7 +24,7 @@ if (typeof PRERENDER === 'undefined') {
ga('create', 'UA-128752250-1', 'auto');
ga('set', 'transport', 'beacon');
ga('set', 'dimension1', displayMode);
ga('send', 'pageview');
ga('send', 'pageview', '/index.html', { title: 'Squoosh' });
// Load the GA script
const s = document.createElement('script');
s.src = 'https://www.google-analytics.com/analytics.js';